• Croquette@sh.itjust.works
    link
    fedilink
    arrow-up
    0
    ·
    7 months ago

    Thanks for the explanation. It makes sense. To my untrained eyes, it feels like both merge and rebase have their use. I will try to keep that in mind.

    • aubeynarf@lemmynsfw.com
      link
      fedilink
      arrow-up
      1
      ·
      6 months ago

      Never use rebase for any branch that has left your machine (been pushed) and which another entity may have a local copy of (especially if that entity may have committed edits to it).

    • JackbyDev@programming.dev
      link
      fedilink
      English
      arrow-up
      0
      ·
      7 months ago

      Yes. They do. A lot of people will use vacuous terms like “clean history” when arguing for one over the other. In my opinion, most repositories have larger problems than rebase versus merge. Like commit messages.

      Also, remember, even if your team/repository prefers merges over rebases for getting changes into the main branch, that doesn’t mean you shouldn’t be using rebase locally for various things.

          • jaemo@sh.itjust.works
            link
            fedilink
            arrow-up
            0
            ·
            7 months ago

            https://gitmoji.dev/

            Quasi parallel reply to your other post, this would kind of echo the want for a capital letter at the start of the commit message. Icon indicates overall topic nature of commits.

            Lets say I am adding a database migration and my commit is the migration file and the schema. My commit message might be:

                 🗃️ Add notes to Users table
            

            So anyone looking at the eventual pr will see the icon and know that this bunch of work will affect db without all that tedious “reading the code” part of the review, or for team members who didn’t participate in reviews.

            I was initially hesitant to adopt it but I have very reasonable, younger team mates for whom emojis are part of the standard vocabulary. I gradually came to appreciate and value the ability to convey more context in my commits this way. I’m still guilty of the occasionally overusing:

               ♻️ Fix the thing
            

            type messages when I’m lazy; doesn’t fix that bad habit, but I’m generally much happier reading mine or someone else’s PR commit summary with this extra bit of context added.

            • Deebster@programming.dev
              link
              fedilink
              arrow-up
              1
              ·
              7 months ago

              I looked at it and there’s a lot of them!

              I see things like adding dependencies but I would add the dependency along with the code that’s using it so I have that context. Is the Gitmoji way to break your commits up so that it matches a single category?

              • jaemo@sh.itjust.works
                link
                fedilink
                arrow-up
                2
                ·
                7 months ago

                Yes, that is another benefit, once you start getting muscle memory with the library. You start to parcel things by context a bit more. It’s upped my habit of discrete commit-by-hunks, which also serves as a nice self-review of the work.

                • Deebster@programming.dev
                  link
                  fedilink
                  English
                  arrow-up
                  1
                  ·
                  edit-2
                  7 months ago

                  I don’t see that as a benefit tbh - if I have a dependency, I want to see why it’s there as part of the commit. I’m imagining running blame on Cargo.toml and seeing “Add feature x” vs “Add dependency”. I guess the idea is it’s “➕ Add dep y for feature x” but I’d still rather be able to see the related code in the same commit instead of having to find the useful commit in the log.

                  I suppose you could squash them together later, but then why bother splitting it out in the first place?

                  I see that some use a subset of Gitmoji and that does make sense to me - after all, you wouldn’t use all of them in every project anyway, e.g. 🏷️ types is only relevant for a few languages.

      • Croquette@sh.itjust.works
        link
        fedilink
        arrow-up
        0
        ·
        7 months ago

        How would rebasing my own branch work? Do I rebase the main into my branch, or make a copy of the main branch and then rebase? I have trouble grasping how that would work.

        • JackbyDev@programming.dev
          link
          fedilink
          English
          arrow-up
          1
          ·
          7 months ago

          You’re still rebasing your branch onto main (or whatever you originally branched it off of), but you aren’t then doing a fast forward merge of main to your branch.

          The terminology gets weird. When people say “merge versus rebase” they really mean it in the context of brining changes into main. You (or the remote repository) cannot do this without a merge. People usually mean “merge commit versus rebase with fast forward merge”